์ด๋ฒคํธ ํฐ์ผ ์์์ ๊ตฌ๋ ํด์ง ๊ฒฝ๊ณ ๋ฉ์์ง ์ถ๊ฐ - #55
Merged
Conversation
Soju06
added a commit
that referenced
this pull request
Feb 20, 2026
์ด๋ฒคํธ ํฐ์ผ ์์์ ๊ตฌ๋ ํด์ง ๊ฒฝ๊ณ ๋ฉ์์ง ์ถ๊ฐ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
๐ ๏ธ PR Summary
๐ ์์ฝ
์ด๋ค ๊ฒ์ด ๋ณ๊ฒฝ๋์๋์? ๊ฐ๋ตํ ์ค๋ช ํด์ฃผ์ธ์.
ํฐ์ผ์ ๋ช ์์ ์ผ๋ก ๊ตฌ๋ ํด์งํ์ง ์์ผ๋ฉด ๊ฒฝ๊ณ ๋ฅผ ๋ฐ์ํ๋ ๋ก์ง์ ์ถ๊ฐํ์ต๋๋ค.
๐ ์ฃผ์ ๋ณ๊ฒฝ ์ฌํญ
์ฃผ์ ๋ณ๊ฒฝ ์ฌํญ์ ์ ์ด์ฃผ์ธ์.
pykis/event/handler.py,pykis/event/filters/product.pyํ์ผ์ ์ด๋ฒคํธ ํํฐ ๊ฐ์ฒด์ repr ํจ์๋ฅผ ์ถ๊ฐํ์ต๋๋ค.pykis/event/handler.py์__del__ํจ์์ ๋ช ์์ ์ผ๋ก ํด์ง๋์ง ์์๋ค๋ฉด ๊ฒฝ๊ณ ๋ฅผ ์ถ๋ ฅํ๋๋ก ์์ ํ์ต๋๋ค.๐ฏ ๋ชฉ์ ๋ฐ ์ํฅ
๋ชฉ์ : ์ ์ด PR์ด ํ์ํ๊ฐ์?
ํฐ์ผ์ ๋ช ์์ ์ผ๋ก ๊ตฌ๋ ํด์งํ์ง ์์ผ๋ฉด ๊ฒฝ๊ณ ๋ฅผ ๋ฐ์ํ์ฌ ์ฌ์ฉ์์๊ฒ ์๋ฆฝ๋๋ค.
์ํฅ: ์ด ๋ณ๊ฒฝ ์ฌํญ์ด ์ด๋ค ์ํฅ์ ๋ฏธ์น๋์?
์๋์น ์๊ฒ ๊ตฌ๋ ํด์ง ๋์์ ๋ ๋ฌธ์ ๋ฅผ ์ถ์ ํ ์ ์์ต๋๋ค.