ORCH-554 Extract project builds and utils into dedicated modules #271
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
08b3866 to
d3bf53d
Compare
852d42f to
be9dedf
Compare
# Conflicts: # sonar-orchestrator-build/src/main/java/com/sonar/orchestrator/build/AbstractBuildExecutor.java # sonar-orchestrator-build/src/main/java/com/sonar/orchestrator/build/AntBuild.java # sonar-orchestrator-build/src/main/java/com/sonar/orchestrator/build/AntBuildExecutor.java # sonar-orchestrator-build/src/main/java/com/sonar/orchestrator/build/Build.java # sonar-orchestrator-build/src/main/java/com/sonar/orchestrator/build/BuildFailureException.java # sonar-orchestrator-build/src/main/java/com/sonar/orchestrator/build/BuildResult.java # sonar-orchestrator-build/src/main/java/com/sonar/orchestrator/build/BuildRunner.java # sonar-orchestrator-build/src/main/java/com/sonar/orchestrator/build/GradleBuild.java # sonar-orchestrator-build/src/main/java/com/sonar/orchestrator/build/GradleBuildExecutor.java # sonar-orchestrator-build/src/main/java/com/sonar/orchestrator/build/MavenBuild.java # sonar-orchestrator-build/src/main/java/com/sonar/orchestrator/build/MavenBuildExecutor.java # sonar-orchestrator-build/src/main/java/com/sonar/orchestrator/build/PropertyUtils.java # sonar-orchestrator-build/src/main/java/com/sonar/orchestrator/build/ScannerForMSBuild.java # sonar-orchestrator-build/src/main/java/com/sonar/orchestrator/build/ScannerForMSBuildExecutor.java # sonar-orchestrator-build/src/main/java/com/sonar/orchestrator/build/ScannerForMSBuildInstaller.java # sonar-orchestrator-build/src/main/java/com/sonar/orchestrator/build/SonarScanner.java # sonar-orchestrator-build/src/main/java/com/sonar/orchestrator/build/SonarScannerExecutor.java # sonar-orchestrator-build/src/main/java/com/sonar/orchestrator/build/SonarScannerInstaller.java # sonar-orchestrator-build/src/main/java/com/sonar/orchestrator/build/coverage/JaCoCoArgumentsBuilder.java # sonar-orchestrator-build/src/main/java/com/sonar/orchestrator/build/dotnet/scanner/PackageDetails.java # sonar-orchestrator-build/src/main/java/com/sonar/orchestrator/build/dotnet/scanner/PackageDetailsFactory.java # sonar-orchestrator-build/src/main/java/com/sonar/orchestrator/build/dotnet/scanner/package-info.java # sonar-orchestrator-build/src/main/java/com/sonar/orchestrator/build/package-info.java # sonar-orchestrator-build/src/main/java/com/sonar/orchestrator/util/Command.java # sonar-orchestrator-build/src/main/java/com/sonar/orchestrator/util/CommandException.java # sonar-orchestrator-build/src/main/java/com/sonar/orchestrator/util/CommandExecutor.java # sonar-orchestrator-build/src/main/java/com/sonar/orchestrator/util/StreamConsumer.java # sonar-orchestrator-build/src/main/java/com/sonar/orchestrator/util/ZipUtils.java # sonar-orchestrator-build/src/main/java/com/sonar/orchestrator/version/Version.java # sonar-orchestrator-build/src/main/java/com/sonar/orchestrator/version/package-info.java # sonar-orchestrator-build/src/test/java/com/sonar/orchestrator/build/AbstractBuildExecutorTest.java # sonar-orchestrator-build/src/test/java/com/sonar/orchestrator/build/AntBuildExecutorTest.java # sonar-orchestrator-build/src/test/java/com/sonar/orchestrator/build/AntBuildTest.java # sonar-orchestrator-build/src/test/java/com/sonar/orchestrator/build/BuildResultTest.java # sonar-orchestrator-build/src/test/java/com/sonar/orchestrator/build/BuildRunnerTest.java # sonar-orchestrator-build/src/test/java/com/sonar/orchestrator/build/BuildTest.java # sonar-orchestrator-build/src/test/java/com/sonar/orchestrator/build/FakeBuild.java # sonar-orchestrator-build/src/test/java/com/sonar/orchestrator/build/GradleBuildExecutorTest.java # sonar-orchestrator-build/src/test/java/com/sonar/orchestrator/build/GradleBuildTest.java # sonar-orchestrator-build/src/test/java/com/sonar/orchestrator/build/MavenBuildExecutorTest.java # sonar-orchestrator-build/src/test/java/com/sonar/orchestrator/build/MavenBuildTest.java # sonar-orchestrator-build/src/test/java/com/sonar/orchestrator/build/PropertyUtilsTest.java # sonar-orchestrator-build/src/test/java/com/sonar/orchestrator/build/ScannerForMSBuildExecutorTest.java # sonar-orchestrator-build/src/test/java/com/sonar/orchestrator/build/ScannerForMSBuildInstallerTest.java # sonar-orchestrator-build/src/test/java/com/sonar/orchestrator/build/ScannerForMSBuildTest.java # sonar-orchestrator-build/src/test/java/com/sonar/orchestrator/build/SonarScannerExecutorTest.java # sonar-orchestrator-build/src/test/java/com/sonar/orchestrator/build/SonarScannerInstallerTest.java # sonar-orchestrator-build/src/test/java/com/sonar/orchestrator/build/SonarScannerTest.java # sonar-orchestrator-build/src/test/java/com/sonar/orchestrator/build/dotnet/scanner/PackageDetailsFactoryTest.java # sonar-orchestrator-build/src/test/java/com/sonar/orchestrator/util/CommandExecutorTest.java # sonar-orchestrator-build/src/test/java/com/sonar/orchestrator/util/CommandTest.java # sonar-orchestrator-build/src/test/java/com/sonar/orchestrator/util/StreamConsumerTest.java # sonar-orchestrator-build/src/test/java/com/sonar/orchestrator/util/ZipUtilsTest.java # sonar-orchestrator-build/src/test/java/com/sonar/orchestrator/version/VersionTest.java
124d7ff to
30a731e
Compare
30a731e to
1be5e0c
Compare
henryju
reviewed
Dec 11, 2025
Member
henryju
left a comment
There was a problem hiding this comment.
I wonder if we should already create another module, orchestrator-utils containing Preconditions, Version, ... that are not really specific to the build.
Contributor
Author
I already saw the opportunity but wanted to scope this task and avoid re-organizing the whole project at once. I'll give it a try. |
|
henryju
approved these changes
Dec 18, 2025
Member
henryju
left a comment
There was a problem hiding this comment.
Very nice!
Don't forget to squad your commits when merging.
You could also request a review from the onprem platform squad, as they are normally the owners of Orchestrator, at least to inform them of the change.
I would also link ORCH-554 to the SCANIT ticket, to give some context to this change.
lukasz-jarocki-sonarsource
approved these changes
Dec 26, 2025
Member
|
This is significant change. Can we bump the version to at least 6.1 (if not 7.0)? |
Contributor
Author
Will do. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://sonarsource.atlassian.net/browse/ORCH-554