SONARJAVA-2466 introduce sonarpedia.json and update rules metadata #1765
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benzonico
reviewed
Oct 31, 2017
| <li> forbid access to <code>java.sql.**</code> from <code>**.ui.**</code> and <code>**.web.**</code> classes </li> | ||
| </ul> | ||
| <h2>Deprecated</h2> | ||
| <p>This rule is deprecated, and will eventually be removed.</p> |
Contributor
There was a problem hiding this comment.
Why remove this ? rule is actually deprecated : https://jira.sonarsource.com/browse/RSPEC-1212
benzonico
reviewed
Oct 31, 2017
| { | ||
| "rules-metadata-path": "./java-checks/src/main/resources/org/sonar/l10n/java/rules/squid", | ||
| "languages": [ | ||
| "JAVA" |
Contributor
There was a problem hiding this comment.
I am surprised by the case of the language in this file cc @erichirlemann
Contributor
There was a problem hiding this comment.
I mean that we have nowhere the java language used in uppercase. The langage key is "java" as defined per https://github.com/SonarSource/sonar-java/blob/master/sonar-java-plugin/src/main/java/org/sonar/plugins/java/Java.java#L39
There was a problem hiding this comment.
This key comes from rule-api instead.
benzonico
reviewed
Oct 31, 2017
| @@ -1 +0,0 @@ | |||
| {"name":"Sonar security way","ruleKeys":[]} | |||
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.