SCANJLIB-287 Replace okhttp by the native JDK HttpClient #268
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8fca049 to
6249e72
Compare
46b331a to
98274f9
Compare
|
lib/src/main/java/org/sonarsource/scanner/lib/internal/http/ScannerHttpClient.java
Show resolved
Hide resolved
aleksandra-bozhinoska-sonarsource
approved these changes
Dec 2, 2025
Contributor
aleksandra-bozhinoska-sonarsource
left a comment
There was a problem hiding this comment.
Code looks good🎉, I ran an analysis with local scanner cli, embedding this version of the library, with no issues.
Just for heads-up, while trying to do that, I got this error message from the enforcer plugin in sonar-scanner-cli (when running mvn verify) I assume due to the now-smaller java-library size, so we will probably need to update the config of the plugin when upgrading the version of the library.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.