SQSCANGHA-146 Add proxy support for GPG keyserver access#244
Merged
Conversation
SummaryThis PR adds automatic proxy support for GPG keyserver access during SonarScanner CLI signature verification. The action now respects Key implementation details:
What reviewers should knowStart with:
Key decisions to review:
Watch for:
|
There was a problem hiding this comment.
Clean, focused implementation. The proxy detection logic, GPG argument construction, and documentation all look correct. One genuine question before approving: the proxy URL is logged to CI output via core.info, which is fine for plain proxy URLs, but some organizations encode credentials directly in proxy URLs (e.g. http://user:password@proxy:8080). Since this action targets corporate proxy environments specifically, it's worth confirming the team is comfortable with that being printed in job logs — or masking it with core.setSecret if credentials in proxy URLs are a realistic concern.
Normalize CRLF to LF in the rollup load hook so Windows checkouts produce the same dist bundle and source maps as Linux/macOS. Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
- Register HTTPS_PROXY as a secret via core.setSecret so embedded credentials (e.g. http://user:pass@proxy:8080) cannot leak to CI logs, and drop the URL from the info message. - Hoist clearProxyEnv()/proxyVars to the outer describe scope in the GPG verification tests (Sonar S4144). dist/ regenerated; this also drops stale chunk files that were no longer emitted by the current rollup config. Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>
|
3 tasks
luketainton
pushed a commit
to luketainton/repos_epage-go
that referenced
this pull request
May 19, 2026
…(#11) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [SonarSource/sonarqube-scan-action](https://github.com/SonarSource/sonarqube-scan-action) | action | minor | `v8.0` → `v8.1` | --- ### Release Notes <details> <summary>SonarSource/sonarqube-scan-action (SonarSource/sonarqube-scan-action)</summary> ### [`v8.1.0`](https://github.com/SonarSource/sonarqube-scan-action/releases/tag/v8.1.0) [Compare Source](SonarSource/sonarqube-scan-action@v8.1.0...v8.1.0) #### What's Changed - SQSCANGHA-146 Add proxy support for GPG keyserver access by [@​henryju](https://github.com/henryju) in [#​244](SonarSource/sonarqube-scan-action#244) - SQSCANGHA-148 Update SonarScanner CLI to 8.1.0.6389 by [@​github-actions](https://github.com/github-actions)\[bot] in [#​232](SonarSource/sonarqube-scan-action#232) **Full Changelog**: <SonarSource/sonarqube-scan-action@v8...v8.1.0> ### [`v8.1`](SonarSource/sonarqube-scan-action@v8...v8.1.0) [Compare Source](SonarSource/sonarqube-scan-action@v8...v8.1.0) </details> --- ### Configuration 📅 **Schedule**: (UTC) - Branch creation - At any time (no schedule defined) - Automerge - At any time (no schedule defined) 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0My4xODUuMCIsInVwZGF0ZWRJblZlciI6IjQzLjE4NS4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJ0eXBlL2RlcGVuZGVuY2llcyJdfQ==--> Reviewed-on: https://git.tainton.uk/repos/epage-go/pulls/11 Co-authored-by: renovate[bot] <[email protected]> Co-committed-by: renovate[bot] <[email protected]>
luketainton
pushed a commit
to luketainton/repos_pypilot
that referenced
this pull request
May 19, 2026
…(#449) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [SonarSource/sonarqube-scan-action](https://github.com/SonarSource/sonarqube-scan-action) | action | minor | `v8.0` → `v8.1` | --- ### Release Notes <details> <summary>SonarSource/sonarqube-scan-action (SonarSource/sonarqube-scan-action)</summary> ### [`v8.1.0`](https://github.com/SonarSource/sonarqube-scan-action/releases/tag/v8.1.0) [Compare Source](SonarSource/sonarqube-scan-action@v8.1.0...v8.1.0) #### What's Changed - SQSCANGHA-146 Add proxy support for GPG keyserver access by [@​henryju](https://github.com/henryju) in [#​244](SonarSource/sonarqube-scan-action#244) - SQSCANGHA-148 Update SonarScanner CLI to 8.1.0.6389 by [@​github-actions](https://github.com/github-actions)\[bot] in [#​232](SonarSource/sonarqube-scan-action#232) **Full Changelog**: <SonarSource/sonarqube-scan-action@v8...v8.1.0> ### [`v8.1`](SonarSource/sonarqube-scan-action@v8...v8.1.0) [Compare Source](SonarSource/sonarqube-scan-action@v8...v8.1.0) </details> --- ### Configuration 📅 **Schedule**: (UTC) - Branch creation - At any time (no schedule defined) - Automerge - At any time (no schedule defined) 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0My4xODUuMCIsInVwZGF0ZWRJblZlciI6IjQzLjE4NS4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJ0eXBlL2RlcGVuZGVuY2llcyJdfQ==--> Reviewed-on: https://git.tainton.uk/repos/pypilot/pulls/449 Co-authored-by: renovate[bot] <[email protected]> Co-committed-by: renovate[bot] <[email protected]>
luketainton
pushed a commit
to luketainton/repos_roboluke
that referenced
this pull request
May 19, 2026
…(#452) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [SonarSource/sonarqube-scan-action](https://github.com/SonarSource/sonarqube-scan-action) | action | minor | `v8.0` → `v8.1` | --- ### Release Notes <details> <summary>SonarSource/sonarqube-scan-action (SonarSource/sonarqube-scan-action)</summary> ### [`v8.1.0`](https://github.com/SonarSource/sonarqube-scan-action/releases/tag/v8.1.0) [Compare Source](SonarSource/sonarqube-scan-action@v8.1.0...v8.1.0) #### What's Changed - SQSCANGHA-146 Add proxy support for GPG keyserver access by [@​henryju](https://github.com/henryju) in [#​244](SonarSource/sonarqube-scan-action#244) - SQSCANGHA-148 Update SonarScanner CLI to 8.1.0.6389 by [@​github-actions](https://github.com/github-actions)\[bot] in [#​232](SonarSource/sonarqube-scan-action#232) **Full Changelog**: <SonarSource/sonarqube-scan-action@v8...v8.1.0> ### [`v8.1`](SonarSource/sonarqube-scan-action@v8...v8.1.0) [Compare Source](SonarSource/sonarqube-scan-action@v8...v8.1.0) </details> --- ### Configuration 📅 **Schedule**: (UTC) - Branch creation - At any time (no schedule defined) - Automerge - At any time (no schedule defined) 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0My4xODUuMCIsInVwZGF0ZWRJblZlciI6IjQzLjE4NS4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJ0eXBlL2RlcGVuZGVuY2llcyJdfQ==--> Reviewed-on: https://git.tainton.uk/repos/roboluke/pulls/452 Co-authored-by: renovate[bot] <[email protected]> Co-committed-by: renovate[bot] <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Internal PR to verify #242