Introduce a setting for the API Key#1032
Merged
jakejarrett merged 1 commit intoSoundnode:masterfrom Jan 5, 2018
Merged
Conversation
Allows users to swap out their API key at runtime
ba408bc to
3f8471b
Compare
Member
Author
|
Merging as this works when tested on OS X, Windows & Linux (Fresh installs) |
|
sounds good. |
Member
|
This is great @jakejarrett! thanks. |
|
Great. Thanks! Does the API key persist if changed? |
Member
Author
|
@brybalicious should do, but need a new build with #1038 in it for it to persist key over multiple launches |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows users to introduce their own API key at any given point.
This isn't a perfect solution, but will give users an option at runtime to swap out the API Key if our api key is killed by the 15k play limit.