Merged
Conversation
Contributor
|
You could use ng-checked for settings view. |
Member
Author
|
@Pitros i'm not too familiar with ng-checked. I'll give it a try and see what i can do. |
Member
Author
|
@Pitros I switched it to ng-checked 👍 Thanks for the heads up (I misunderstood what ng-checked was for initially) |
Contributor
|
Now it looks simplier 👍 , ng-model on input probably should work as well but that's a quick note. |
b432f90 to
a735f6f
Compare
a735f6f to
03fab73
Compare
Member
|
Looks good @jakejarrett thanks for working on this.. pretty cool feature. |
Member
|
I'm just going to do some refactoring although everything works great. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a settings page to Soundnode & Ability to disable desktop notifications from soundnode.
Also adds keyboard shortcut ( control/cmd + , )
Closes #382