Open song/artist page by clicking on a song/artist title in the player.#410
Merged
weblancaster merged 1 commit intoSoundnode:masterfrom Oct 23, 2015
mradionov:player-goto-song-artist
Merged
Open song/artist page by clicking on a song/artist title in the player.#410weblancaster merged 1 commit intoSoundnode:masterfrom mradionov:player-goto-song-artist
weblancaster merged 1 commit intoSoundnode:masterfrom
mradionov:player-goto-song-artist
Conversation
Member
|
@mradionov looks good this way.. thanks for working on it and sorry for my delay in review. |
weblancaster
added a commit
that referenced
this pull request
Oct 23, 2015
Open song/artist page by clicking on a song/artist title in the player.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows to open song page by clicking on it's title or logo in the player and to open artist page by clicking on his name in the player. It is available on the SC website and I think is useful.
Basically I've added one more property to a track object, which is getting created by
playerService-songUserId- using API data fromtracks.htmlandplaylists.html.Also I've used
ng-clickapproach because from my research data for player is added in real-time via DOM API fromplayerService(like appending track name and inserting logo), so just appendingui-srefthe same way won't work. I wonder though if I should have added a method toplayerServiceto get current track object instead of accessingqueueServicedirectly from a controller.