fix #364: Hide reposts in stream#425
Merged
weblancaster merged 1 commit intoSoundnode:masterfrom Oct 26, 2015
mradionov:hide-reposts-in-stream
Merged
fix #364: Hide reposts in stream#425weblancaster merged 1 commit intoSoundnode:masterfrom mradionov:hide-reposts-in-stream
weblancaster merged 1 commit intoSoundnode:masterfrom
mradionov:hide-reposts-in-stream
Conversation
Fixes: #364
Member
|
Great thanks @mradionov works like a charm. |
weblancaster
added a commit
that referenced
this pull request
Oct 26, 2015
fix #364: Hide reposts in stream
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #364
After a few tests on SoundCloud website, in case when one track has a lot of reposts in stream, it seems that only the very first appearance of the track is displayed. By removing all duplicates all the side effects described in the original issue go away.
To re-create this behavior I'm filtering loaded tracks for unique ids.