Feature: Show and make reposts - integrate SoundCloud API v2 [in progress]#430
Feature: Show and make reposts - integrate SoundCloud API v2 [in progress]#430weblancaster merged 1 commit intoSoundnode:masterfrom mradionov:show-and-make-reposts
Conversation
|
@mradionov ok cool, let me know when it's done and I will review and test. Thanks. |
|
@weblancaster , I guess I am on the finish line, only some refactoring and a little bit more testing left. It would be great if you could take a look at the PR. Summary of the last 4 commits:
I plan to do some refactoring (plus adding comment to code), making fixes according to your notes and eventually squashing the commits. Thanks! |
|
@weblancaster , PR is finished from my side. Additional fixes from latest updates:
It's up to you to decide whether or not should it end up in the app because of v2 API and undocumented API |
|
Great @mradionov I'm going to look into this today.. thanks. |
|
Hey @mradionov the code looks good but I found two issues.
|
|
@weblancaster , thanks for the feedback. May I ask you what do you mean by "Major" tracks? |
|
I can't play any track.. so that's a major issue. |
|
Oh, that's weird. By the way, I have kinda the same thing when I'm running the app using "nw" command, but when I build the app - tracks can be played again. It is not related to this PR though, I've discovered that from the beginning of me trying to work with a project, maybe you know what can cause this behavior? Can tracks be played in a built version of the app in your case regarding this PR? I have Ubuntu 14.04. |
|
I built but still not working.. when I go back to master branch songs play normally so must be something in this PR that broke that @mradionov |
|
Yeah, I've found the reason, on my way to fix it. Thanks |
|
Great thanks. |
|
Fixed those two bugs that you've mentioned. |
|
Great @mradionov thanks for your hard work.. ps: playlist still not looking exactly like before haha but it's minor this time. |
Feature: Show and make reposts - integrate SoundCloud API v2 [in progress]



Note: work is still in progress
Implementation of #291: show reposts and allow to make resposts.
As discussed in the issue, it is possible to work with reposts only using SoundCloud API v2. In this PR:
trackproperty of collection item (originproperty for v1 API) and it does not haveuser_favoriteprop, so it is now set by force.Basically, I would love to hear some feedback if I am going in the right direction and may continue working on reposts using this base. I am not sure if the entire application should be migrated to v2 at once. Thanks!