Scale window & Save scale across sessions#453
Conversation
d9b1fd6 to
35ccd8a
Compare
|
Why not |
|
I agree with @wb9688 can we change the keyboard shortcut @jakejarrett |
Sets scale of window with mod+shift + +/-/0 This will be useful for users on HiDPI screens
|
@weblancaster updated the pull request with @wb9688's suggestion |
|
Thanks @jakejarrett I did some tests and code review (comments added to the files change/commit) When I fresh start the App and press the shortcut keyboard to zoom-in this is what I get at first, then if I close the app and open again because we have saved the scale number on localStorage if I press the shortcut keyboard to zoom-in again works as expected. So I would suggest to define a scale right at the beginning. here's the screenshot |
There was a problem hiding this comment.
you should define the currentScale and newScale vars at the top and then re-assign.
var currentScale;
var newScale;then you can just do currentScale = whateverValueYouWant
There was a problem hiding this comment.
Can we in a way remove the conditions here because you can perhaps just send the value number from the shortcuts method e.g scaleWindow(-0.1) or scaleWindow(0.1)
|
I can merge and work on the fix if you'd prefer that. |
|
If you want to work on the fix @weblancaster that'd be dope 😄 I was having issues with the scaling up when just adding 0.1 to the zoom. (idk why) |
|
Ok then, I'm merging into master and going improve the code. |
Scale window & Save scale across sessions
sets scale of window with mod+shift + +/-/0
This will be useful for users on HiDPI screens
demo of scaling in action