Fix track like button hover state#626
Merged
Pitros merged 1 commit intoSoundnode:masterfrom Jun 20, 2016
Pitros:fix_track_like_button
Merged
Fix track like button hover state#626Pitros merged 1 commit intoSoundnode:masterfrom Pitros:fix_track_like_button
Pitros merged 1 commit intoSoundnode:masterfrom
Pitros:fix_track_like_button
Conversation
Member
|
We shouldn't show play when hovering like. |
Contributor
Author
|
@weblancaster but my PR fixes that bug... |
Member
|
Can you describe the bug please @Pitros |
Contributor
Author
|
Currently when you hover on like button while being on track page, play icon shows up on track atwork because one variable is used in both places. Just like on the video i've attached. |
Member
|
Oh ok now I got it.. I thought you were actually adding this feature. can you fix the conflicts and I will merge. thanks @Pitros |
Contributor
Author
|
@weblancaster fixed. |
|
The mp4 link is dead due to dropbox rate limiting. Could you rehost somewhere else for the record? |
Contributor
Author
|
Please launch the app, go to track page for any tack you want and hover on like button to see that atwork hover state is also triggered. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for that nice behavior.