Fixing the problem with duplicated songs in the "Likes" area#703
Closed
jogacolhue wants to merge 1 commit intoSoundnode:masterfrom
Closed
Fixing the problem with duplicated songs in the "Likes" area#703jogacolhue wants to merge 1 commit intoSoundnode:masterfrom
jogacolhue wants to merge 1 commit intoSoundnode:masterfrom
Conversation
…ime a person reaches the end of the scroll.
Closed
|
Duplicates still occurring in v0.6.3 |
Author
|
Have you tried using my fork?, the solution isn't still merged with the master branch. |
|
Sorry, new to GitHub; how do I access your fork? |
Member
|
from master branch. 'git fetch origin pull/703/head:fix-duplicated' then |
Member
|
Thanks @DrJosepon but this was fixed in #713 for all views. |
Author
|
NP, gotta be more careful next time. |
Member
|
the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Each time a person reaches the end of the scroll in the "Likes" area of the app, a double load of songs happen, like in #702 , the problem was that in the function of the favoritesCtrl.js there were two scopes in the "for" ($scope.originalData.push( data.collection[i] ) and $scope.data.push( data.collection[i] ).
I fixed this by looking at the tracksCtrl.js where only "$scope.data.push()" is needed to work.