Logged in user text links to their profile page (fix #642)#733
Merged
weblancaster merged 2 commits intoSoundnode:masterfrom Jul 1, 2016
Merged
Logged in user text links to their profile page (fix #642)#733weblancaster merged 2 commits intoSoundnode:masterfrom
weblancaster merged 2 commits intoSoundnode:masterfrom
Conversation
Contributor
Author
|
Just commenting to see what you think @weblancaster. Anything else to do before a merge? |
Member
|
hey @dgattey my apologies with my super delay in testing this PR. I was going to merge but before I tested and turns out there is a minor issue.. the reason is that you need to add a null check on the profileCtrl where we call replace.
I'm merging and then fix myself so we don't prolong. |
weblancaster
pushed a commit
that referenced
this pull request
Jul 1, 2016
weblancaster
added a commit
that referenced
this pull request
Jul 1, 2016
add fix to user-profile-link PR. #733
Contributor
Author
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Click the username at top left to link to their profile page per #642. Doesn't show reposts, but ordinary profiles don't show reposts, so loading reposts should be a separate issue IMO. A few changes came together for this: