Quick fixes for errors in JS execution + artist names on follower pages#738
Merged
jakejarrett merged 1 commit intoSoundnode:masterfrom Apr 29, 2016
Merged
Quick fixes for errors in JS execution + artist names on follower pages#738jakejarrett merged 1 commit intoSoundnode:masterfrom
jakejarrett merged 1 commit intoSoundnode:masterfrom
Conversation
…es link to the artist
Contributor
Author
|
Anything to fix here? If not, what can I do to help merge it in? |
Member
|
I'll test this tonight |
Member
|
@dgattey Tested it finally (sorry for the delay) Everything looks good to me. |
Member
|
Thanks @dgattey and thanks @jakejarrett for testing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found a few small JS bugs related to data returned from the API that I fixed, plus an inconsistency in HTML I fixed.
data.descriptionwould exist. Simple null check.