Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fixes scrubbing issues with mouse and window#750

Merged
weblancaster merged 1 commit intoSoundnode:masterfrom
sillero:master
Jul 1, 2016
Merged

Fixes scrubbing issues with mouse and window#750
weblancaster merged 1 commit intoSoundnode:masterfrom
sillero:master

Conversation

@sillero
Copy link

@sillero sillero commented Apr 23, 2016

fixes #516

  • 1px margin on the progress bar to detect when the mouse is leaving the window horizontally (effectively no visual impact)
  • dynamic vertical threshold to better manage the mouse behavior on scrubbing
  • needed to detect the gui.window focus/blur, so I'm dispatching it to jQuery too, which should also be useful in other scenarios

@weblancaster
Copy link
Member

weblancaster commented Jul 1, 2016

Awesome work @sillero thanks a lot and sorry for my delay in reviewing.

@weblancaster weblancaster merged commit 98dce9d into Soundnode:master Jul 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[BUG] Onmouse event for scrubbing doesnt end after leaving window

2 participants

@sillero @weblancaster