Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Support LMOVE #2065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Apr 10, 2022
Merged

Support LMOVE #2065

merged 13 commits into from
Apr 10, 2022

Conversation

Avital-Fine
Copy link
Contributor

NickCraver
NickCraver requested changes Apr 4, 2022
View reviewed changes
Copy link
Collaborator

@NickCraver NickCraver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! I left comments inline - note that #2041 is a major change we wanted to get in before tons of PRs here (per #2055) and will make merging a bit difficult. I wanted to throw a note in here in case unaware. I'll do me best to help merge main into these after NRTs lands.

NickCraver
NickCraver reviewed Apr 4, 2022
View reviewed changes
@NickCraver
Copy link
Collaborator

@Avital-Fine for tests, check out the format Skip.IfMissingFeature(conn, nameof(RedisFeatures.PushMultiple), f => f.PushMultiple); - we need to so similar for LMOVE there for testing against older servers :)

@Avital-Fine Avital-Fine requested a review from NickCraver April 4, 2022 15:17
@Avital-Fine
Copy link
Contributor Author

Thanks for this! I left comments inline - note that #2041 is a major change we wanted to get in before tons of PRs here (per #2055) and will make merging a bit difficult. I wanted to throw a note in here in case unaware. I'll do me best to help merge main into these after NRTs lands.

Thank you! hope the merge won't be too bad 😅

NickCraver
NickCraver requested changes Apr 8, 2022
View reviewed changes
Copy link
Collaborator

@NickCraver NickCraver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few tweaks/removals then I think we're good to go - thanks for this!

src/StackExchange.Redis/RedisDatabase.cs Outdated

public RedisValue ListMove(RedisKey sourceKey, RedisKey destinationKey, ListSide whereFrom, ListSide whereTo, CommandFlags flags = CommandFlags.None)
{
var msg = Message.Create(Database, flags, RedisCommand.LMOVE, sourceKey, destinationKey, whereFrom == ListSide.Left ? "Left" : "right", whereTo == ListSide.Left ? "Left" : "right");
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should be consistent in Left vs right here :)

tests/StackExchange.Redis.Tests/Lists.cs
Skip.IfMissingFeature(conn, nameof(RedisFeatures.PushMultiple), f => f.PushMultiple);
var db = conn.GetDatabase();
RedisKey key = "testlist";
RedisKey key = Me();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for these fixes btw!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure!

slorello89
slorello89 approved these changes Apr 10, 2022
View reviewed changes
Copy link
Collaborator

@slorello89 slorello89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Avital-Fine Avital-Fine requested a review from NickCraver April 10, 2022 12:33
NickCraver
NickCraver approved these changes Apr 10, 2022
View reviewed changes
Copy link
Collaborator

@NickCraver NickCraver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looking good

@NickCraver NickCraver merged commit 35fab74 into StackExchange:main Apr 10, 2022
@NickCraver NickCraver mentioned this pull request Apr 10, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NickCraver NickCraver NickCraver approved these changes

@slorello89 slorello89 slorello89 approved these changes

Assignees
No one assigned
Labels
⚙️ area:API ⚙️ area:commands ➕ enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Avital-Fine @NickCraver @slorello89