Make it easier to use user certificate files #2873
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Historically, certs only worked with PFX files, which made it a pain to work with the cert pairs typically downloaded from hosts like Redis Ltd; however, on more recent .NET versions PEM is fully available. Here, we:
ConfigurationOptions
(akin to the existingTrustIssuer
method) to configure certificates from filesThere are no tests added here, due to the inherent problems of CI talking to such servers; however:
works with the files downloaded from my hosted Redis Ltd endpoint:
To @philon-msft : open question: can we check Azure Redis with similar?
^^^ update: Philo assures me that Azure Redis doesn't have any relevant client-cert scenarios to consider