Add xtrim with minid and new 8.2 stream features #2912
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clarify doc comment i now think the XTRIM documentation is saying that an entry at exactly MINID is kept. https://redis.io/docs/latest/commands/xtrim/
implement useApproximateMaxLength and limit as per docs
add xackdel
Closed
philon-msft
approved these changes
Jul 18, 2025
This was referenced Sep 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds minid support from #2842 (adopts PR)
Adds new 8.2 stream features:
Also changes
int?length-related usage in stream APIs tolong?in the new overloads (only). Binary and compile compat retained throughout; some args made non-optional to push callers to new API when possible.High level (beyond minid) is that a bunch of stream methods (or new methods) gain
[KEEPREF|DELREF|ACKED]support, whereKEEPREFis the old approach and assumed by default when not mandatory. For more context, seeStreamTrimModeenum comments.