imagePullSecrets is a top-level attribute of ServiceAccounts - #239
Merged
Merged
Conversation
cognifloyd
enabled auto-merge
September 6, 2021 14:36
Member
Author
|
@armab We need this one for the next release. |
arm4b
approved these changes
Sep 7, 2021
arm4b
left a comment
Member
There was a problem hiding this comment.
Looks good, but we'll still need a Changelog here 👍
Otherwise, it will be hard for people to fast-track the issues they experienced that might be silently fixed by us.
Member
Author
|
This fixes the syntax for #196 which has not been released yet. No one had been able to use this feature yet since it has been broken since it was introduced. Why do we need another entry? |
Member
|
There are folks who rely on the latest master chart and so the Changelog is always preferred as a way of tracking and sharing the progress and fixes. |
cognifloyd
force-pushed
the
fix-sa-pullsecret
branch
from
September 7, 2021 21:43
3a4212e to
1a9c52f
Compare
cognifloyd
force-pushed
the
fix-sa-pullsecret
branch
from
September 7, 2021 22:22
1a9c52f to
6715904
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #227