Add image.entrypoint value to support custom entrypoints like dumb-init - #413
Merged
Merged
Conversation
cognifloyd
commented
Apr 11, 2024
image.entrypoint value to support custom image entrypoints like dumb-init
image.entrypoint value to support custom image entrypoints like dumb-initimage.entrypoint value to support custom entrypoints like dumb-init
cognifloyd
commented
Apr 11, 2024
|
|
||
| {{- define "stackstorm-ha.st2-entrypoint" -}} | ||
| {{- range $.Values.image.entrypoint }} | ||
| - {{ toYaml . }} |
Member
Author
There was a problem hiding this comment.
The point of toYaml is to quote the string if needed.
winem
approved these changes
Apr 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My actionrunner pods have exhausted the pid space due to zombie processes. So, we need something to cleanup those zombies.
dumb-initdoes that. See:Installing
dumb-init,pid1, or some other entrypoint app requires installing it in the docker image (ie we have to update the docker images). But, the chart also needs to support the older images that don't include it. So, hard-coding the entry-point is not an option. Once we update the docker images to install an init process, we can update the default value in the chart to include that init process, but still allow people using an older image to set that value to[]and still use the chart.Also, we would still need to include the init command in the chart somehow (not just in the docker image's
ENTRYPOINT) because the chart overwrites the command baked into the images to pass additional config files. So, making this a value seems to be a good path forward.