Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Calls base class constructor when generating python code. #430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
adamfk merged 1 commit into from
Jan 8, 2025
Merged

Calls base class constructor when generating python code. #430

adamfk merged 1 commit into from
Jan 8, 2025

Conversation

@alexis-boisserand
Copy link

@alexis-boisserand alexis-boisserand commented Jan 7, 2025

In Python, if a constructor is declared, it has to explicitly call the base class constructor, otherwise it's never called.
Currently the generated class constructor looks something like this:

    # State machine constructor. Must be called before start or dispatch event functions. Not thread safe.
    def __init__(self):
        # Used internally by state machine. Feel free to inspect, but don't modify.
        self.stateId = None

This PR modifies the inherited class constructor, so that the base class constructor gets called with any parameter it needs.

    # State machine constructor. Must be called before start or dispatch event functions. Not thread safe.
    def __init__(self, *args, **kwargs):
        super().__init__(*args, **kwargs)
        # Used internally by state machine. Feel free to inspect, but don't modify.
        self.stateId = None

@alexis-boisserand alexis-boisserand changed the title Calls base class constructor. Calls base class constructor when generating python code. Jan 7, 2025
adamfk
adamfk approved these changes Jan 8, 2025
View reviewed changes
Copy link
Contributor

@adamfk adamfk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! It might be a few days before I have to time to properly release it.

@adamfk adamfk merged commit 56e18de into StateSmith:main Jan 8, 2025
4 checks passed
@adamfk
Copy link
Contributor

adamfk commented Jan 8, 2025

I added you to the changelog. Thanks again! https://github.com/StateSmith/StateSmith/blob/main/CHANGELOG.md?plain=1#L35-L41

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adamfk adamfk adamfk approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@alexis-boisserand @adamfk @alexis-boisserand-acuity