lib - simulator - slight improvements to drop down settings menu #487
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamfk
commented
Jul 27, 2025
| right: 0; | ||
| background-color: #f1f1f1; | ||
| min-width: 160px; | ||
| min-width: 250px; |
Contributor
Author
There was a problem hiding this comment.
needed for longer Hide ignored event buttons label
adamfk
commented
Jul 27, 2025
| .dropbtn:hover, .dropbtn:focus { | ||
| .dropdown-button:hover, .dropdown-button:focus { |
Contributor
Author
There was a problem hiding this comment.
using full english words so that it is hopefully easier for non-english speaking contributors to translate
adamfk
commented
Jul 27, 2025
| <span id='dropdown-button' class='titlebar-icon dropdown-button'>settings</span> | ||
| <div id='myDropdown' class='dropdown-content'> | ||
| <label class='dropdown-item' for='hideIrrelevantEvents' | ||
| title='When enabled, event dispatching buttons will be hidden if the current active state(s) ignore the event.'> |
adamfk
commented
Jul 27, 2025
| <div id='myDropdown' class='dropdown-content'> | ||
| <label class='dropdown-item' for='hideIrrelevantEvents' | ||
| title='When enabled, event dispatching buttons will be hidden if the current active state(s) ignore the event.'> | ||
| <input type='checkbox' id='hideIrrelevantEvents' name='hideIrrelevantEvents'> |
Contributor
Author
There was a problem hiding this comment.
moved checkbox inside of label so that clickable area is larger and matches css hover highlighting
Contributor
Author
adamfk
added a commit
that referenced
this pull request
Jul 28, 2025
adamfk
added a commit
that referenced
this pull request
Jul 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some small quality of life improvements and tidy.
Before:
After:
