Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Added proposed solution to Fs NoneType error - issue 9100 #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 11, 2020
Merged

Added proposed solution to Fs NoneType error - issue 9100 #3

merged 2 commits into from
Mar 11, 2020

Conversation

Stefan-Mitic
Copy link
Owner

@Stefan-Mitic Stefan-Mitic commented Mar 10, 2020 •
edited
Loading

PR Summary

Added check to set Fs in _axes.specgram() to be Fs = freq[-1] * 2.
Added a test to test_axes.py to check if Fs is None that it won't throw an error.

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

KJBBato
KJBBato approved these changes Mar 10, 2020
View reviewed changes
Copy link
Collaborator

@KJBBato KJBBato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good. Does not produce any side effects with the new changes.

@Stefan-Mitic Stefan-Mitic merged commit 4d42b7c into master Mar 11, 2020
Stefan-Mitic pushed a commit that referenced this pull request Mar 28, 2020
Added proposed solution to Fs NoneType error - issue 9100 (#3)
2751304 
* fix: added check for value of Fs

* test: created test for specgram Fs is none
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KJBBato KJBBato KJBBato approved these changes

@leungbyr leungbyr Awaiting requested review from leungbyr

@evannwang evannwang Awaiting requested review from evannwang

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Stefan-Mitic @KJBBato