Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Feat: support warpbuild cache provider #247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 24, 2025
Merged

Feat: support warpbuild cache provider #247

merged 1 commit into from
Jun 24, 2025

Conversation

stegaBOB
Copy link
Contributor

This adds support for using WarpBuild's caching action: https://github.com/WarpBuilds/cache

The purpose of the interface is because their action has slightly different optional parameters in the saveCache function. They are not being used.

@stegaBOB stegaBOB force-pushed the stegaBOB/feat/warpbuild branch from 983dfc5 to efcd79a Compare June 18, 2025 17:10
Swatinem
Swatinem approved these changes Jun 20, 2025
View reviewed changes
Copy link
Owner

@Swatinem Swatinem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice. I think removing the pnpm lockfile is the only thing I would ask you to do still.

@Swatinem
Copy link
Owner

Another thing would be, if warpbuild is free for open source, we could add an example, similar to buildjet: https://github.com/Swatinem/rust-cache/blob/master/.github/workflows/buildjet.yml

Those example are doubling as integration tests as well.

@Swatinem
Copy link
Owner

@stegaBOB I think this only needs a rebase. I bumped a bunch of test dependencies that were causing CI failures.

@stegaBOB
Copy link
Contributor Author

Another thing would be, if warpbuild is free for open source, we could add an example, similar to buildjet: https://github.com/Swatinem/rust-cache/blob/master/.github/workflows/buildjet.yml

I had this locally but it wasn't working on my fork unfortunately. I don't think they are free for open source. FWIW, we're currently using my fork for some of our runners with warpbuild and it works so far.

@stegaBOB stegaBOB force-pushed the stegaBOB/feat/warpbuild branch from efcd79a to f29739b Compare June 24, 2025 16:51
@Swatinem Swatinem merged commit 52ea143 into Swatinem:master Jun 24, 2025
22 checks passed
@stegaBOB
Copy link
Contributor Author

Hey @Swatinem thanks for getting this in!! Would it be possible to release a new tag or retag v2 with these changes?

@Swatinem
Copy link
Owner

done. thank you for your contribution :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Swatinem Swatinem Swatinem approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stegaBOB @Swatinem