chore(dependabot): regenerate and commit dist/ #257
Conversation
|
This doesn't regenerate the already merged patches. |
| fetch-depth: 2 | ||
| # if: steps.metadata.outputs.update-type == 'version-update:semver-patch' | ||
| - name: Check if package-lock.json has been changed | ||
| if: steps.metadata.outputs.update-type == 'version-update:semver-patch' |
There was a problem hiding this comment.
I think you want to do this for all kinds of dependabot updates unconditionally
There was a problem hiding this comment.
I wouldn't do that, we already saw patches breaking CI 😞
And as I mentioned, currently there is no connection to any other CI jobs, even if any of them (eventually) fail this workflow will be executed, all run in parallel to each other.
Current conditions:
- if a new PR has been created
- if the author is dependabot
- if update_type is patch
de9d902 to
97d397d
Compare
|
Ah yes, I understand now, this is only the automerge job, and minor/major bumps are not set up that way. so for those, it will still be necessary to manually regenerate those files, oh well :-( |
|
Well, there could be a new workflow which regenerates dist/ for all pull requests if package-lock.json has been changed 😄 |
Chores