Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat(cli): allow disabling automated parameter detection in renku run #3548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 6, 2023
Merged

feat(cli): allow disabling automated parameter detection in renku run #3548

merged 5 commits into from
Jul 6, 2023

Conversation

Panaetius
Copy link
Member

closes #3504

@Panaetius Panaetius requested a review from a team as a code owner July 5, 2023 14:49
@Panaetius Panaetius force-pushed the feat/3504-duplicate-parameter-usage-in-api branch from d87e2fb to 098fde4 Compare July 5, 2023 14:50
@coveralls
Copy link
Collaborator

coveralls commented Jul 5, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 5475885438

  • 26 of 53 (49.06%) changed or added relevant lines in 4 files are covered.
  • 367 unchanged lines in 34 files lost coverage.
  • Overall coverage increased (+5.4%) to 85.896%
Changes Missing Coverage Covered Lines Changed/Added Lines %
renku/core/workflow/plan_factory.py 18 24 75.0%
renku/domain_model/workflow/parameter.py 4 25 16.0%
Files with Coverage Reduction New Missed Lines %
renku/command/schema/dataset.py 1 92.37%
renku/core/dataset/providers/api.py 1 83.26%
renku/core/dataset/providers/common.py 1 94.44%
renku/core/dataset/providers/repository.py 1 88.46%
renku/core/dataset/providers/s3.py 1 96.25%
renku/core/dataset/providers/web.py 1 89.91%
renku/core/migration/m_0003__1_jsonld.py 1 87.68%
renku/core/migration/models/v3.py 1 97.24%
renku/core/storage.py 1 79.79%
renku/core/util/os.py 1 88.89%
Totals Coverage Status
Change from base Build 5475079123: 5.4%
Covered Lines: 25877
Relevant Lines: 30126
💛 - Coveralls

olevski
olevski previously approved these changes Jul 6, 2023
View reviewed changes
Copy link
Member

@olevski olevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few optional suggestions. If you commit changes ping me and I will re-approve.

@Panaetius Panaetius requested a review from olevski July 6, 2023 12:12
olevski
olevski approved these changes Jul 6, 2023
View reviewed changes
Copy link
Member

@olevski olevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@Panaetius Panaetius enabled auto-merge (squash) July 6, 2023 13:12
@Panaetius Panaetius merged commit bcdeba1 into develop Jul 6, 2023
@Panaetius Panaetius deleted the feat/3504-duplicate-parameter-usage-in-api branch July 6, 2023 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olevski olevski olevski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
renku-python
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unclear messaging for error in using workflows
3 participants
@Panaetius @coveralls @olevski