Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add AUDIT-IGNORE.md file with CVE info#172

Merged
Rafikooo merged 1 commit into
Sylius:1.0from
michalkaczmarek-bitbag:audit-ignore-md-file
Nov 17, 2025
Merged

Add AUDIT-IGNORE.md file with CVE info#172
Rafikooo merged 1 commit into
Sylius:1.0from
michalkaczmarek-bitbag:audit-ignore-md-file

Conversation

@michalkaczmarek-bitbag
Copy link
Copy Markdown
Contributor

Q A
Branch? 1.0
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Related tickets
License MIT

Add info about CVE ignored by composer.

@Rafikooo Rafikooo changed the title Add md file with info CVE Add AUDIT-IGNORE.md file with CVE info Nov 17, 2025
@Rafikooo Rafikooo merged commit 2404243 into Sylius:1.0 Nov 17, 2025
1 check passed
Rafikooo added a commit to michalkaczmarek-bitbag/InvoicingPlugin that referenced this pull request Nov 20, 2025
- Add comprehensive CVE ignore list to composer.json (API Platform, Twig, Symfony)
- Create AUDIT-IGNORE.md with detailed CVE documentation
- Replace symfony security:check with composer audit --locked --abandoned=ignore

The symfony security:check command doesn't respect composer.json ignore configuration,
causing CI failures despite CVE advisories being intentionally ignored. Switching to
composer audit ensures the ignore list is properly respected.

Following patterns from:
- Sylius/Sylius#18553
- Sylius/Sylius#18549
- Sylius/AdyenPlugin#172
Rafikooo added a commit to michalkaczmarek-bitbag/InvoicingPlugin that referenced this pull request Nov 20, 2025
- Add comprehensive CVE ignore list to composer.json (API Platform, Twig, Symfony)
- Create AUDIT-IGNORE.md with detailed CVE documentation
- Replace symfony security:check with composer audit --locked --abandoned=ignore

The symfony security:check command doesn't respect composer.json ignore configuration,
causing CI failures despite CVE advisories being intentionally ignored. Switching to
composer audit ensures the ignore list is properly respected.

Following patterns from:
- Sylius/Sylius#18553
- Sylius/Sylius#18549
- Sylius/AdyenPlugin#172
GSadee added a commit to Sylius/InvoicingPlugin that referenced this pull request Nov 20, 2025
| Q               | A
|-----------------|-----
| Branch?         | 1.0
| Bug fix?        | yes
| New feature?    | no
| BC breaks?      | no
| Deprecations?   | no
| Related tickets | 
| License         | MIT

## Summary

Fix CI build by adding CVE filtering to composer audit ignore list and
updating security check workflow.

## Changes

1. **composer.json** - Added CVE advisories to `config.audit.ignore`:
   - `PKSA-gs8r-6kz6-pp56` (api-platform/core CVE-2025-31485)
   - `PKSA-gnn4-pxdg-q76m` (api-platform/core CVE-2025-31481)
   - `PKSA-yhcn-xrg3-68b1` (twig/twig CVE-2024-45411)
   - `PKSA-2wrf-1xmk-1pky` (twig/twig CVE-2024-51755)
   - `PKSA-365x-2zjk-pt47` (symfony/http-foundation CVE-2025-64500)

2. **AUDIT-IGNORE.md** - Created documentation file explaining why each
CVE is ignored (following pattern from Sylius/Sylius#18553)

3. **build.yaml** - Changed security check command from `symfony
security:check` to `composer audit --locked --abandoned=ignore`

## Why switch from `symfony security:check` to `composer audit`?

**Official Symfony documentation recommends `composer audit` for CI:**
> "In continuous integration services you can check security
vulnerabilities by running the `composer audit` command."
> 
> Source:
https://symfony.com/doc/current/setup.html#checking-security-vulnerabilities

**Key advantages:**
- ✅ `composer audit` respects ignore configuration in `composer.json` 
- ✅ Built into Composer 2.4+ - no need to install Symfony CLI in CI
- ✅ Allows selective ignoring of specific CVEs with justification
- ❌ `symfony security:check` has NO support for ignore configuration
- ❌ Would require `continue-on-error: true` (ignores ALL errors, not
just known CVEs)

Following the same approach as:
- Sylius/Sylius#18553
- Sylius/Sylius#18549
- Sylius/AdyenPlugin#172
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants