minor #15706 Try SyliusResourceBundle 1.11 & SyliusGridBundle 1.13 (loic425)

NoResponseMate · web-flow · commit 97c94269af0f · 2024-08-28T13:39:57.000+02:00
This PR was merged into the 1.13 branch. Discussion ---------- | Q | A | |-----------------|--------------------------------------------------------------| | Branch? | 1.13 | | Bug fix? | no | | New feature? | no | | BC breaks? | no | | Deprecations? | no | | Related tickets | | | License | MIT |  Inspired by #15119 Commits ------- Try SyliusGridBundle 1.13 Both resource and grid unstable versions Apply suggestions from code review [Resource] Add validation for translatable interface with new namespace Minor CS fix in workflow
diff --git a/.github/workflows/ci_e2e-custom.yaml b/.github/workflows/ci_e2e-custom.yaml
@@ -14,9 +14,9 @@ permissions:
     contents: read
 
 jobs:
-    behat-no-js-unstable-symfony:
+    behat-no-js-unstable-dependencies:
         runs-on: ubuntu-latest
-        name: "Non-JS, PHP ${{ matrix.php }}, Symfony ${{ matrix.symfony }}, MySQL ${{ matrix.mysql }} (Unstable Dependencies)"
+        name: "Non-JS, PHP ${{ matrix.php }}, Symfony ${{ matrix.symfony }}, MySQL ${{ matrix.mysql }}, Resource ${{ matrix.resource }}, Grid ${{ matrix.grid }} (Unstable Dependencies)"
         timeout-minutes: 45
         continue-on-error: true
         strategy:
@@ -25,6 +25,8 @@ jobs:
                 php: [ "8.1" ]
                 symfony: [ "^6.4" ]
                 mysql: [ "8.0" ]
+                resource: ["^1.11@dev"]
+                grid: [ "^1.13@dev" ]
 
         env:
             APP_ENV: test_cached
@@ -57,6 +59,14 @@ jobs:
                     composer config minimum-stability dev
                     composer config prefer-stable true
 
+            -   name: Require SyliusResourceBundle version
+                run: |
+                    composer require sylius/resource-bundle:${{ matrix.resource }} --no-update    
+                    
+            -   name: Require SyliusGridBundle version
+                run: |
+                    composer require sylius/grid-bundle:${{ matrix.grid }} --no-update                    
+
             -   name: Build application
                 uses: SyliusLabs/BuildTestAppAction@v2.2
                 with:
diff --git a/src/Sylius/Bundle/CoreBundle/Resources/config/validation/TranslatableInterface.xml b/src/Sylius/Bundle/CoreBundle/Resources/config/validation/TranslatableInterface.xml
@@ -17,4 +17,10 @@
             <option name="groups">sylius</option>
         </constraint>
     </class>
+
+    <class name="Sylius\Resource\Model\TranslatableInterface">
+        <constraint name="Sylius\Bundle\CoreBundle\Validator\Constraints\TranslationForExistingLocales">
+            <option name="groups">sylius</option>
+        </constraint>
+    </class>
 </constraint-mapping>
