Try SyliusResourceBundle 1.11#15119
Closed
Zales0123 wants to merge 1 commit into
Closed
Conversation
620ddb2 to
931d6cf
Compare
Contributor
|
I rebased your PR, as we merged all needed CI fixes 🖖🏻. |
loic425
reviewed
Jun 23, 2023
| - php: "8.1" | ||
| symfony: "^6.3" | ||
| mysql: "8.0" | ||
| resource: "^1.11@dev" |
Member
There was a problem hiding this comment.
I'm just wondering if now we prefer to test the dev or the alpha release.
I think dev is better to test it before new releases.
Contributor
|
Closing as #15706 seems to do the same thing 🖖🏻. |
NoResponseMate
added a commit
that referenced
this pull request
Aug 28, 2024
…oic425) This PR was merged into the 1.13 branch. Discussion ---------- | Q | A | |-----------------|--------------------------------------------------------------| | Branch? | 1.13 | | Bug fix? | no | | New feature? | no | | BC breaks? | no | | Deprecations? | no | | Related tickets | | | License | MIT | <!-- - Bug fixes must be submitted against the 1.12 branch - Features and deprecations must be submitted against the 1.13 branch - Make sure that the correct base branch is set To be sure you are not breaking any Backward Compatibilities, check the documentation: https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html --> Inspired by #15119 Commits ------- Try SyliusGridBundle 1.13 Both resource and grid unstable versions Apply suggestions from code review [Resource] Add validation for translatable interface with new namespace Minor CS fix in workflow
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Let's give it a try 🎉 The build should be passing (see this build) but it's failing because of the problem fixed here 🖖