Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[API] Association types improvements#11337

Merged
pamil merged 1 commit into
Sylius:masterfrom
lchrusciel:association-types
Apr 9, 2020
Merged

[API] Association types improvements#11337
pamil merged 1 commit into
Sylius:masterfrom
lchrusciel:association-types

Conversation

@lchrusciel
Copy link
Copy Markdown
Contributor

@lchrusciel lchrusciel commented Apr 7, 2020

Q A
Branch? master
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Related tickets part of #11250, improvements from #11319
License MIT

@lchrusciel lchrusciel requested a review from a team as a code owner April 7, 2020 13:41
Copy link
Copy Markdown
Contributor

@oallain oallain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lchrusciel 🎉

You can remove the use Symfony\Component\Serializer\SerializerInterface; at https://github.com/Sylius/Sylius/pull/11337/files#diff-9f9847e886745cd71df41b26b4816ae1R23

@Zales0123 Zales0123 added API APIs related issues and PRs. Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.). labels Apr 8, 2020
Copy link
Copy Markdown
Contributor

@pamil pamil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More of those changes, please 🎈

@pamil pamil merged commit 47a0684 into Sylius:master Apr 9, 2020
@pamil
Copy link
Copy Markdown
Contributor

pamil commented Apr 9, 2020

Thanks, Łukasz! 🥇

@lchrusciel lchrusciel deleted the association-types branch April 10, 2020 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

API APIs related issues and PRs. Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants