[API] product association type#11319
Merged
Merged
Conversation
12 tasks
381af73 to
5084275
Compare
lchrusciel
reviewed
Apr 3, 2020
Contributor
lchrusciel
left a comment
There was a problem hiding this comment.
Hey Olivier,
thanks for your effort ;)
| */ | ||
| public function iNameItIn(string $productAssociationTypeName = null, string $localeCode = 'en_US'): void | ||
| { | ||
| $this->client->updateRequestData(['translations' => [$localeCode => ['name' => $productAssociationTypeName, 'locale' => $localeCode]]]); |
Contributor
There was a problem hiding this comment.
Can we break it into multiple lines?
lchrusciel
approved these changes
Apr 7, 2020
|
|
||
| @ui | ||
| @ui @api | ||
| Scenario: Deleting multiple product association types at once |
Contributor
There was a problem hiding this comment.
We have decided to skip these features because we weren't sure how should we process multiple deletions, but thanks for your proposal! ;)
| } | ||
|
|
||
| /** | ||
| * @Then this product association type name should be :name |
Contributor
There was a problem hiding this comment.
Same as https://github.com/Sylius/Sylius/pull/11319/files#diff-9f9847e886745cd71df41b26b4816ae1R166
Suggested change
| * @Then this product association type name should be :name | |
| * @Then /^(this product association type) name should be "([^"]+)"$/ |
| } | ||
|
|
||
| /** | ||
| * @Then the code field should be disabled |
Contributor
There was a problem hiding this comment.
During implementing new steps, we have decided, that we would like to slightly adjust these steps to something like https://github.com/Sylius/Sylius/pull/11178/files#diff-32a4b0d263dad520cfb84a0704f82849R24
Contributor
|
Thanks, @oallain! 🎉 |
pamil
added a commit
that referenced
this pull request
Apr 9, 2020
This PR was merged into the 1.6-dev branch. Discussion ---------- | Q | A | --------------- | ----- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Related tickets | part of #11250, improvements from #11319 | License | MIT <!-- - Bug fixes must be submitted against the 1.6 or 1.7 branches (the lowest possible) - Features and deprecations must be submitted against the master branch - Make sure that the correct base branch is set --> Commits ------- ce9964f [API] Association types improvements
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.