Conflict liip/imagine-bundle ^2.7#13261
Conversation
|
I would add a conflict until a fix it's released. |
add5906 to
d71406f
Compare
| "symfony/property-info": "4.4.22 || 5.2.7", | ||
| "symfony/serializer": "4.4.19 || 5.2.2" | ||
| "symfony/serializer": "4.4.19 || 5.2.2", | ||
| "liip/imagine-bundle": "^2.7" |
There was a problem hiding this comment.
Can you add a note to CONFLICT.md about it?
There was a problem hiding this comment.
Is there a particular reason the conflict note was never added? I'm actually slightly curious what the "issue" is after the bugs reported in 2.7.0 were fixed in 2.7.1.
There was a problem hiding this comment.
@mbabker there was an issue with always resolving the image cache as webp, checking only if the browser supports webp and not if webp is enabled in configuration as well.
Related PR: https://github.com/liip/LiipImagineBundle/pull/1410/files
There was a problem hiding this comment.
I'm aware of that issue, it's fixed in 2.7.1. So why is the conflict the equivalent of >=2.7.0, <3.0.0?
|
Thank you, Mateusz! 🎉 |
Psalm complains about it after upgrading liip/imagine-bundle to 2.7. We should probably think about bumping the bundle's version and using the new configuration soonEDIT: I conflict with
liip/imagine-bundle:^2.7for now, due to some other problems. Thanks, @mynameisbogdan for the suggestion 🖖