Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conflict liip/imagine-bundle ^2.7 #13261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lchrusciel merged 1 commit into from
Oct 29, 2021
Merged

Conflict liip/imagine-bundle ^2.7 #13261

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,8 @@
"symfony/doctrine-bridge": "4.4.16",
"symfony/polyfill-mbstring": "^1.22.0",
"symfony/property-info": "4.4.22 || 5.2.7",
"symfony/serializer": "4.4.19 || 5.2.2"
"symfony/serializer": "4.4.19 || 5.2.2",
"liip/imagine-bundle": "^2.7"
Copy link
Copy Markdown
Contributor

@lchrusciel lchrusciel Oct 29, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a note to CONFLICT.md about it?

Copy link
Copy Markdown
Contributor

@mbabker mbabker Nov 11, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a particular reason the conflict note was never added? I'm actually slightly curious what the "issue" is after the bugs reported in 2.7.0 were fixed in 2.7.1.

Copy link
Copy Markdown

@mynameisbogdan mynameisbogdan Nov 11, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mbabker there was an issue with always resolving the image cache as webp, checking only if the browser supports webp and not if webp is enabled in configuration as well.

Related PR: https://github.com/liip/LiipImagineBundle/pull/1410/files

Copy link
Copy Markdown
Contributor

@mbabker mbabker Nov 11, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm aware of that issue, it's fixed in 2.7.1. So why is the conflict the equivalent of >=2.7.0, <3.0.0?

Copy link
Copy Markdown
Contributor

@stloyd stloyd Nov 11, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mbabker Here is PR to relax the rule: #13288

},
"require-dev": {
"ext-json": "*",
Expand Down