default shipping methods order by position#14940
Merged
Merged
Conversation
Contributor
|
Hello @ehibes , Thank you for your contribution. First, please rebase the PR. Second, it would be great if you would add a behat test that covers such a feature 💃 |
Contributor
Author
NoResponseMate
previously approved these changes
May 9, 2023
…in_cart_summary_based_on_method_position.feature Co-authored-by: Jan Góralski <[email protected]>
NoResponseMate
approved these changes
May 10, 2023
jakubtobiasz
approved these changes
May 10, 2023
Rafikooo
approved these changes
May 10, 2023
coldic3
approved these changes
May 12, 2023
| Feature: Viewing a cart summary with the correct default shipping method | ||
| In order to see details about my order | ||
| As a Visitor | ||
| I want see my cart summary with the correct shipping method based on its position |
Contributor
There was a problem hiding this comment.
Suggested change
| I want see my cart summary with the correct shipping method based on its position | |
| I want to see my cart summary with the correct shipping method based on its position |
| /** | ||
| * @Given /^the store(?:| also) allows shipping with "([^"]+)" at position (\d+) with ("[^"]+") fee$/ | ||
| */ | ||
| public function theStoreAllowsShippingMethodWithNameAndPositionAndFee($name, $position, $fee): void |
Contributor
There was a problem hiding this comment.
Suggested change
| public function theStoreAllowsShippingMethodWithNameAndPositionAndFee($name, $position, $fee): void | |
| public function theStoreAllowsShippingMethodWithNameAndPositionAndFee(string $name, int $position, $fee): void |
Contributor
|
Thank you, @ehibes! |
jakubtobiasz
added a commit
that referenced
this pull request
May 12, 2023
This PR was merged into the 1.12 branch. Discussion ---------- | Q | A | |-----------------|--------------------------------------------------------------| | Branch? | 1.12 | | Bug fix? | no | | New feature? | no | | BC breaks? | no | | Deprecations? | no | | Related tickets | follow up to #14940 | | License | MIT | Commits ------- [Behat] Minor fixes in ShippingContext [Behat] Minor fix in a scenario
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I propose this modification, in order that the default shipping method is selected according to the position of the methods in the admin, even when the customer does not have an address yet.