Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix build (1.3)#10101

Merged
pamil merged 2 commits into
Sylius:1.3from
Zales0123:1.3-fix-build
Jan 15, 2019
Merged

Fix build (1.3)#10101
pamil merged 2 commits into
Sylius:1.3from
Zales0123:1.3-fix-build

Conversation

@Zales0123
Copy link
Copy Markdown
Contributor

@Zales0123 Zales0123 commented Jan 15, 2019

Q A
Branch? 1.3
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Related tickets related to #10094
License MIT

Is there any possibility to avoid duplicated routing files in test/ and test_cached/? ⚖️

@Zales0123 Zales0123 added the Potential Bug Potential bugs or bugfixes, that needs to be reproduced. label Jan 15, 2019
@Zales0123 Zales0123 requested a review from a team as a code owner January 15, 2019 12:24
@pamil
Copy link
Copy Markdown
Contributor

pamil commented Jan 15, 2019

Oops, I deleted that TestAppKernel.php in a merge commit by an accident, could you bring it back in this PR?

@pamil
Copy link
Copy Markdown
Contributor

pamil commented Jan 15, 2019

As for loading test config in test_cached environment, I think importing files by a glob pattern should work, but I'd leave that for another PR.

@pamil pamil merged commit 64f2b81 into Sylius:1.3 Jan 15, 2019
@pamil
Copy link
Copy Markdown
Contributor

pamil commented Jan 15, 2019

Thanks, Mateusz! 🥇

@Zales0123 Zales0123 deleted the 1.3-fix-build branch January 15, 2019 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Potential Bug Potential bugs or bugfixes, that needs to be reproduced.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants