Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Product Review] fixed review validation when edited by admin #10118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pamil merged 1 commit into from
Jan 25, 2019
Merged

[Product Review] fixed review validation when edited by admin #10118

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion features/product/managing_product_reviews/editing_product_review.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ Feature: Editing product reviews
I want to edit a product review

Background:
Given the store has customer "Mike Ross" with email "[email protected]"
Given there is a customer "Mike Ross" with an email "[email protected]" and a password "thePassword"
And the store has a product "Lamborghini Gallardo Model"
And this product has a review titled "Awesome" and rated 4 with a comment "Nice product" added by customer "[email protected]"
And I am logged in as an administrator
Expand Down
1 change: 1 addition & 0 deletions src/Sylius/Bundle/AdminBundle/Resources/config/services.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
<import resource="services/email.xml" />
<import resource="services/listener.xml" />
<import resource="services/menu.xml" />
<import resource="services/form.xml" />
</imports>

<services>
Expand Down
20 changes: 20 additions & 0 deletions src/Sylius/Bundle/AdminBundle/Resources/config/services/form.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
<?xml version="1.0" encoding="UTF-8"?>

<!--

This file is part of the Sylius package.

(c) Paweł Jędrzejewski

For the full copyright and license information, please view the LICENSE
file that was distributed with this source code.

-->

<container xmlns="http://symfony.com/schema/dic/services" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://symfony.com/schema/dic/services http://symfony.com/schema/dic/services/services-1.0.xsd">
<parameters>
<parameter key="sylius.form.type.product_review.validation_groups" type="collection">
<parameter>sylius</parameter>
</parameter>
</parameters>
</container>
2 changes: 1 addition & 1 deletion src/Sylius/Bundle/ReviewBundle/Resources/config/validation/Review.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
<constraint name="NotBlank">
<option name="message">sylius.review.title.not_blank</option>
<option name="groups">
<value>sylius_review</value>
<value>sylius</value>
</option>
</constraint>
<constraint name="Length">
Expand Down