Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Upgrade guide from v1.2.x to v1.4.0#10130

Merged
pamil merged 2 commits into
Sylius:1.4from
Zales0123:upgrade-guide-12-14
Jan 31, 2019
Merged

Upgrade guide from v1.2.x to v1.4.0#10130
pamil merged 2 commits into
Sylius:1.4from
Zales0123:upgrade-guide-12-14

Conversation

@Zales0123
Copy link
Copy Markdown
Contributor

Q A
Branch? master
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Related tickets
License MIT

@Zales0123 Zales0123 added Documentation Documentation related issues and PRs - requests, fixes, proposals. Maintenance CI configurations, READMEs, releases, etc. labels Jan 30, 2019
@Zales0123 Zales0123 requested a review from a team as a code owner January 30, 2019 14:32
Comment thread UPGRADE-1.4.md
- { resource: "services_test.yaml" }
```
* If you use our Travis CI configuration, follow [theses changes](https://github.com/Sylius/Sylius-Standard/pull/323/files#diff-354f30a63fb0907d4ad57269548329e3) introduced in `.travis.yml` file
* If you use our Travis CI configuration, follow [these](https://github.com/Sylius/Sylius-Standard/pull/322/files#diff-354f30a63fb0907d4ad57269548329e3)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we create a dummy PR on Sylius-Standard with 1.3...1.4 diff, close & lock it and then use it for diffs? It would require one link then.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 but I would also vote to do it in a separate PR, to have the whole UPGRADE guide already written (as it's working) and just improve it, wdyt?

Comment thread UPGRADE-1.4.md
* If you use our Travis CI configuration, follow [these](https://github.com/Sylius/Sylius-Standard/pull/322/files#diff-354f30a63fb0907d4ad57269548329e3)
and [these](https://github.com/Sylius/Sylius-Standard/pull/323/files#diff-354f30a63fb0907d4ad57269548329e3) changes introduced in `.travis.yml` file

---
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doubled ---

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was intentional, to separate 2 upgrade sections in a more visible way :)

Comment thread UPGRADE-1.4.md Outdated
@Zales0123 Zales0123 force-pushed the upgrade-guide-12-14 branch 3 times, most recently from 1f781ac to b06d08b Compare January 31, 2019 08:59
@pamil pamil changed the base branch from master to 1.4 January 31, 2019 10:05
@pamil
Copy link
Copy Markdown
Contributor

pamil commented Jan 31, 2019

The base of this pull-request was changed, you need fetch and reset your local branch
if you want to add new commits to this pull request. Reset before you pull, else commits
may become messed-up.

Unless you added new commits (to this branch) locally that you did not push yet,
execute git fetch origin && git reset "upgrade-guide-12-14" to update your local branch.

Feel free to ask for assistance when you get stuck 👍

@pamil pamil force-pushed the upgrade-guide-12-14 branch from b06d08b to fcce64e Compare January 31, 2019 10:05
@pamil pamil merged commit ebc9590 into Sylius:1.4 Jan 31, 2019
@pamil
Copy link
Copy Markdown
Contributor

pamil commented Jan 31, 2019

Thank you, Mateusz! 🎉

@Zales0123 Zales0123 deleted the upgrade-guide-12-14 branch March 29, 2019 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Documentation Documentation related issues and PRs - requests, fixes, proposals. Maintenance CI configurations, READMEs, releases, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants