fixes #10173, wrong regular expression for locale#10178
Merged
Zales0123 merged 2 commits intoApr 8, 2019
Conversation
superbull
commented
Feb 18, 2019
| Q | A |
|---|---|
| Branch? | 1.3 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Related tickets | fixes #10173 |
| License | MIT |
Contributor
|
It looks good, but I would add a scenario with extended locale in this file, to prevent us from possible issues. Would you be able to do it @superbull? Thanks! 🚀 |
Author
|
OK, I can do it. |
Contributor
|
ping @superbull, any update on this one? :) |
GSadee
approved these changes
Apr 8, 2019
Zales0123
approved these changes
Apr 8, 2019
Contributor
|
Thank you, Deng! 🥇 |
Author
|
@Zales0123 My pleasure! 😊 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.