Allowing options to be given with resource[0].id syntax#10199
Merged
Conversation
When customizing grids quite a lot, we might get a queryBuilder returning an array of array instead of an array of entities. this array is built like this :
```php
$result = [
0 => new Resource(),
'custom_value' => 8,
'other_custom_value' => 'aaa',
]
```
And for this reason, it might be usefull to allow this kind of option parsing.
pamil
suggested changes
Mar 11, 2019
Contributor
pamil
left a comment
There was a problem hiding this comment.
Could you add some tests for it?
Contributor
|
ping @Roshyo :) |
Contributor
Author
|
Oh yeah indeed. I totally forgot this. What sort of tests should I add ? |
Contributor
|
Some unit test in |
Contributor
Author
|
Here we are. |
Contributor
Author
|
ping @pamil @Zales0123 |
lchrusciel
approved these changes
Apr 19, 2019
GSadee
approved these changes
Apr 19, 2019
Contributor
|
Thanks, Stephane! 🎉 |
Contributor
Author
|
Thanks to you ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When customizing grids quite a lot, we might get a queryBuilder returning an array of array instead of an array of entities. this array is built like this :
And for this reason, it might be usefull to allow this kind of option parsing.