Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Taxonomy tree modified - 'go level up' moved to the end of tree#10243

Merged
pamil merged 1 commit into
Sylius:1.3from
AdamKasp:taxonomy-tree-issue
Mar 22, 2019
Merged

Taxonomy tree modified - 'go level up' moved to the end of tree#10243
pamil merged 1 commit into
Sylius:1.3from
AdamKasp:taxonomy-tree-issue

Conversation

@AdamKasp
Copy link
Copy Markdown
Contributor

@AdamKasp AdamKasp commented Mar 19, 2019

Q A
Branch? 1.3
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Related tickets fixes #9903
License MIT

Screenshot 2019-03-19 at 10 38 43

@AdamKasp AdamKasp requested a review from a team as a code owner March 19, 2019 09:43
@AdamKasp AdamKasp force-pushed the taxonomy-tree-issue branch from 8ad47b3 to 62a41be Compare March 19, 2019 09:54
@Zales0123 Zales0123 changed the base branch from master to 1.3 March 19, 2019 10:03
@Zales0123 Zales0123 force-pushed the taxonomy-tree-issue branch from 62a41be to 5d21a38 Compare March 19, 2019 10:03
@Zales0123
Copy link
Copy Markdown
Contributor

The base of this pull-request was changed, you need fetch and reset your local branch
if you want to add new commits to this pull request. Reset before you pull, else commits
may become messed-up.

Unless you added new commits (to this branch) locally that you did not push yet,
execute git fetch origin && git reset "taxonomy-tree-issue" to update your local branch.

Feel free to ask for assistance when you get stuck 👍

@Zales0123 Zales0123 added Potential Bug Potential bugs or bugfixes, that needs to be reproduced. UX Issues and PRs aimed at improving User eXperience. and removed Potential Bug Potential bugs or bugfixes, that needs to be reproduced. labels Mar 19, 2019
<div class="ui fluid vertical menu">
<div class="header item">{{ taxon.name }}</div>
{% for child in taxon.children %}
<a href="{{ path('sylius_shop_product_index', {'slug': child.slug, '_locale': child.translation.locale}) }}" class="item">{{ child.name }}</a>
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could be indented, as we are touching these lines anyway

@pamil pamil merged commit fc677cc into Sylius:1.3 Mar 22, 2019
@pamil
Copy link
Copy Markdown
Contributor

pamil commented Mar 22, 2019

Thanks, Adam! 🥇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

UX Issues and PRs aimed at improving User eXperience.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants