[Product] Fixed products sorting by price#10274
Conversation
Updated the createShopListQueryBuilder method of ProductRepository to get rid of the SQL error that causes a 500 one when trying to sort products by price in the shop.
|
The base of this pull-request was changed, you need fetch and reset your local branch Unless you added new commits (to this branch) locally that you did not push yet, Feel free to ask for assistance when you get stuck 👍 |
|
Thank you for the fix, @laSyntez! I was wondering why our Behat scenarios did not fail (we have them for sorting in |
|
@Zales0123 it will break in other MYSQL versions too, if |
…Syntez) This PR was merged into the 1.4 branch. Discussion ---------- | Q | A | --------------- | ----- | Branch? | 1.4 | Bug fix? | yes | New feature? | yes | BC breaks? | no | Deprecations? | no | Related tickets | fixes #10266, replaces #10274 | License | MIT The bug from issue #10266 has not been detected on Travis CI, due to the lower mySQL version (without `ONLY_FULL_GROUP_BY` option set). So this PR bumps the mySQL version on the Travis to **5.7** and contains the fix for the products sorting from #10274 (thank @laSyntez for this one!). As a proof that it didn't work without the fix, you can take a look at [this build](https://travis-ci.org/Zales0123/Sylius/builds/512912936) or check out our failing demo 🚀 🤣 We have also a PR with changing the ubuntu version on Travis to xenial (#10277), but it does not work for some reasons so bumping a mySQL version can be the first step 🖖 Commits ------- 230a508 mySQL 5.7 on Travis 968722e [Product] Fixed products sorting by price
|
Glad to have been able to give a hand @Zales0123 👍. |
Updated the createShopListQueryBuilder method of ProductRepository to get rid of the SQL error that causes a 500 one when trying to sort products by price in the shop.