Codestin Search App

cyrosy · 2019-09-26T09:36:49Z

I introduced 2 changes in the AddressBook JS handler, allowing address form to be extended with more freedom :

checkbox and radio values won't be set to empty string, and will be correctly checked
prevent input field name collisions : the value of one field could be duplicated in multiple fields with similar names (for instance, the value of « street » would override the value of a « street2 » or « streetComp » field)

This should not break anything in core Sylius. If you think I should rebase this on another branch, just ask as this will be quite easy to adapt :)

pamil · 2019-10-04T11:08:46Z

Thanks, Cyro! 🥇

cyrosy added 2 commits September 26, 2019 11:27

[AddressBook] allow input of type checkbox or radio in address form

85a71f8

[AddressBook] match field names more strictly to prevent name collisions

c55cda4

cyrosy requested a review from a team as a code owner September 26, 2019 09:36

lchrusciel assigned kulczy Sep 27, 2019

pamil approved these changes Oct 4, 2019

View reviewed changes

pamil added the Feature New feature proposals. label Oct 4, 2019

pamil merged commit dfc252f into Sylius:1.4 Oct 4, 2019

pamil added Potential Bug Potential bugs or bugfixes, that needs to be reproduced. and removed Feature New feature proposals. labels Oct 4, 2019

cyrosy deleted the feature/address-book-improvements branch October 4, 2019 11:59

kulczy removed their assignment Apr 14, 2024

Provide feedback