[Docs] Plugins technical review checklist#10731
Merged
GSadee merged 3 commits intoOct 29, 2019
Merged
Conversation
pamil
reviewed
Oct 4, 2019
lchrusciel
approved these changes
Oct 20, 2019
GSadee
approved these changes
Oct 29, 2019
Co-Authored-By: Grzegorz Sadowski <[email protected]>
Member
|
Thank you, Mateusz! 🥇 |
lchrusciel
added a commit
that referenced
this pull request
Dec 11, 2019
… (Zales0123) This PR was merged into the 1.6 branch. Discussion ---------- | Q | A | --------------- | ----- | Branch? | 1.6 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Related tickets | | License | MIT This PR contains changes from #10731, which in fact should be from the beginning opened to `1.6` 😄 Due to the release of Sylius Store, I propose a slightly new approach to approving/accepting plugins. We want to develop our plugins ecosystem, but on the other hand, we still want to keep the high quality of these extensions. There is also a new way to propose plugins to our plugins list - a [plugin request submit form](https://store.sylius.com/submit). So my proposal is to accept all the plugins that work, provide a valuable extension to Sylius features and is documented enough to make installation as less problematic as possible. On the other hand, only plugins that fulfill more strict requirements from the "Should have" section, can get an "Approved by Sylius" badge. I believe it will be a better change for both Sylius users and developers 🏅 Let me know what you think about it 🖖 Commits ------- 1fe0b86 [Docs] Plugins technical review checklist ccefb84 PR review fixes 8c9a42f Fix recommended tests name 5a40edd Move tests requirements to "Should have" with an explanation e5ce6c9 Plugins technical requirement changes due to Sylius Store release
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the very beginning of the Sylius plugins system, we are giving the availability to make your plugin officially approved. This technical review checklist is a detailed instruction what you should focus on, to make the approval process smoother and faster 🎉