Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add lint:container command to the build & fix errors reported by it#10926

Merged
lchrusciel merged 3 commits into
Sylius:1.5from
pamil:1.5-lint-container
Dec 11, 2019
Merged

Add lint:container command to the build & fix errors reported by it#10926
lchrusciel merged 3 commits into
Sylius:1.5from
pamil:1.5-lint-container

Conversation

@pamil
Copy link
Copy Markdown
Contributor

@pamil pamil commented Dec 11, 2019

Q A
Branch? 1.5
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Related tickets -
License MIT

Removes services defined for nonexisting classes and fixes other container-related errors.
Adds lint:container command to the build.

https://symfony.com/blog/new-in-symfony-4-4-service-container-linter

@pamil pamil requested a review from a team as a code owner December 11, 2019 15:56
@pamil pamil changed the title | Q | A | --------------- | ----- | Branch? | 1.5 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Related tickets | - | License | MIT Add lint:container command to the build & fix errors reported by it Dec 11, 2019
@pamil pamil added Potential Bug Potential bugs or bugfixes, that needs to be reproduced. Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.). Maintenance CI configurations, READMEs, releases, etc. labels Dec 11, 2019
@lchrusciel
Copy link
Copy Markdown
Contributor

Fixes: #10866

@lchrusciel lchrusciel merged commit 3bf7ac4 into Sylius:1.5 Dec 11, 2019
@lchrusciel
Copy link
Copy Markdown
Contributor

Thanks, Kamil! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.). Maintenance CI configurations, READMEs, releases, etc. Potential Bug Potential bugs or bugfixes, that needs to be reproduced.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants