Yaml standards#10943
Conversation
| autowire: true | ||
| autoconfigure: true | ||
|
|
||
| # Uncomment any lines below to activate that Twig extension |
There was a problem hiding this comment.
I'll be happy to merge this PR as soon as those lines are ignored by the tool.
There was a problem hiding this comment.
Hello,
I set line indent by his depths but comment line may not have any style. So, if comment line has nearest next non-comment line I set indent by that line but if comment line doesn't have non-comment line I set him zero indents because he does not belong to anyone.
I agree it's not perfect but I think it's the best solution.
How exactly do you imagine logic to skip exactly these lines? 🤔 If you want all comment lines at the end set by nearest non-comment line then it can be not good for another repository where they write at the end some note, for example.
Sorry, if it looks aggressive but it's not 😄 I am only unhappy because I don't know how I can help you with this problem.
What do you think about edit that line to more indents and when you remove # they will have right indents? 🤔
services:
_defaults:
public: false
autowire: true
autoconfigure: true
# Uncomment any lines below to activate that Twig extension
# Twig\Extensions\ArrayExtension: ~
# Twig\Extensions\DateExtension: ~
# Twig\Extensions\IntlExtension: ~
# Twig\Extensions\TextExtension: ~instead of
services:
_defaults:
public: false
autowire: true
autoconfigure: true
# Uncomment any lines below to activate that Twig extension
#Twig\Extensions\ArrayExtension: ~
#Twig\Extensions\DateExtension: ~
#Twig\Extensions\IntlExtension: ~
#Twig\Extensions\TextExtension: ~What do you think?
There was a problem hiding this comment.
Makes sense! Anyway, after giving it a bit more time, we don't really need this file at all in Sylius/Sylius repo :)
- fixed wrong files
- fixed wrong files
61bd62d to
b49854d
Compare
|
The base of this pull-request was changed, you need fetch and reset your local branch Unless you added new commits (to this branch) locally that you did not push yet, Feel free to ask for assistance when you get stuck 👍 |
|
Thank you, Peter! 🎉 |
|
I thank you too 😊 |
Hello,
I would like to offer you library which helps you observe some standards.
As you can see I added 3 commits:
Library of course has more standards but some don't have fixer or it's not relevant for you, so I didn't add it.
Do you have any questions? Something doesn't like you? Feel free to ask 😊
Thank you in advance 🤝