[Hot-Fix] Fix failing specs after prophecy update#10962
Merged
Conversation
GSadee
approved these changes
Dec 18, 2019
pamil
approved these changes
Dec 18, 2019
pamil
approved these changes
Dec 18, 2019
Contributor
|
Thank you, Mateusz! 🥇 |
pamil
added a commit
that referenced
this pull request
Dec 18, 2019
This PR was merged into the 1.5 branch. Discussion ---------- | Q | A | --------------- | ----- | Branch? | 1.5 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Related tickets | | License | MIT #10962 It should be done from this branch 💃 Commits ------- 988e973 [Hot-Fix] Fix failing specs after prophecy update 75c5d61 Make PHPStan passing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems that these specs should never work 😄 The problem is, it's hard to specify setting a cloned object... especially if in one of this case we also have some value changed 💃 So this is obviously not a final fix, but at least it should fix a build 🚀