Require Symfony ^4.4#10970
Merged
Merged
Conversation
GSadee
approved these changes
Dec 18, 2019
Contributor
Author
|
No idea why PHP 7.2 application build fails :/ |
Contributor
I feel like it's just a lag time that has lasted too long (more than 10 minutes). I think relaunching the build can validate (or not) this idea ;) |
bcb5c5f to
32d60d9
Compare
Zales0123
reviewed
Jan 16, 2020
Contributor
Zales0123
left a comment
There was a problem hiding this comment.
After fixing some problems in the packages build it should be ready to go 💃 🚀
Tomanhez
approved these changes
Jan 16, 2020
lchrusciel
approved these changes
Jan 16, 2020
| */ | ||
| public function it_autoconfigures_cart_contexts_and_order_processors(): void | ||
| { | ||
| $this->markTestSkipped('Symfony 4.4 makes it impossible to test autoconfigured services this way.'); |
Contributor
There was a problem hiding this comment.
Maybe we should just remove this test then.
Contributor
|
Thanks, Kamil! 🥇 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.