Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fixtures: fix French translation of cap#11192

Merged
pamil merged 2 commits into
Sylius:1.6from
dunglas:patch-1
Mar 6, 2020
Merged

Fixtures: fix French translation of cap#11192
pamil merged 2 commits into
Sylius:1.6from
dunglas:patch-1

Conversation

@dunglas
Copy link
Copy Markdown
Contributor

@dunglas dunglas commented Mar 6, 2020

Q A
Branch? master
Bug fix? yes
New feature? yes
BC breaks? yes
Deprecations? no
Related tickets n/a
License MIT

image

This isn't a "casquette", it's a "bonnet" 😅

@dunglas dunglas requested a review from a team as a code owner March 6, 2020 13:14
@Pierstoval
Copy link
Copy Markdown

You sure? 😅
image

@dunglas
Copy link
Copy Markdown
Contributor Author

dunglas commented Mar 6, 2020

According to the product’s picture it’s definitely a « bonnet », even if there is only one word for both « casquette » and « bonnet » in English.

@Pierstoval
Copy link
Copy Markdown

Oh, I didn't understand why you were talking about pictures, but the picture didn't actually show on my browser 😅 I opened it with another browser and I saw it.

Totally okay then 👍

@Zales0123 Zales0123 added the Potential Bug Potential bugs or bugfixes, that needs to be reproduced. label Mar 6, 2020
Copy link
Copy Markdown
Contributor

@Zales0123 Zales0123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As you're a native, I suppose you're right 😄 👍

Comment thread src/Sylius/Bundle/CoreBundle/Resources/config/app/fixtures/cap.yaml Outdated
@romainricard
Copy link
Copy Markdown

romainricard commented Mar 6, 2020

As you're a native, I suppose you're right

Seconded, this is a bonnet in French.

@Zales0123 Zales0123 changed the base branch from master to 1.6 March 6, 2020 14:49
@Zales0123
Copy link
Copy Markdown
Contributor

The base of this pull-request was changed, you need fetch and reset your local branch
if you want to add new commits to this pull request. Reset before you pull, else commits
may become messed-up.

Unless you added new commits (to this branch) locally that you did not push yet,
execute git fetch origin && git reset "patch-1" to update your local branch.

Feel free to ask for assistance when you get stuck 👍

@pamil pamil merged commit 64c1f8d into Sylius:1.6 Mar 6, 2020
@pamil
Copy link
Copy Markdown
Contributor

pamil commented Mar 6, 2020

Thanks, Kévin! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Potential Bug Potential bugs or bugfixes, that needs to be reproduced.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants