[API] Update UPGRADE-1.8 file after adding ApiBundle#11288
Merged
Conversation
Member
GSadee
commented
Mar 25, 2020
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Related tickets | |
| License | MIT |
lchrusciel
approved these changes
Mar 25, 2020
Zales0123
approved these changes
Mar 25, 2020
Contributor
|
Thanks, Grzegorz! 🥇 |
stloyd
reviewed
Mar 26, 2020
| + anonymous: true | ||
| + provider: sylius_admin_api_user_provider | ||
| + json_login: | ||
| + check_path: /new-api/authentication-token |
Contributor
There was a problem hiding this comment.
Shouldn't this be also with regexp?
check_path: "%sylius.security.new_api_admin_regex%/authentication-token"
Contributor
There was a problem hiding this comment.
It should. Would you like to open a PR?
lchrusciel
added a commit
that referenced
this pull request
Mar 26, 2020
… (stloyd) This PR was merged into the 1.8-dev branch. Discussion ---------- | Q | A | --------------- | ----- | Branch? | 1.8 | Bug fix? | yes(?) | New feature? | no | BC breaks? | no | Deprecations? | no | Related tickets | mentioned in #11288 | License | MIT <!-- - Bug fixes must be submitted against the 1.6 or 1.7 branches (the lowest possible) - Features and deprecations must be submitted against the master branch - Make sure that the correct base branch is set --> Commits ------- 4c95aa5 Fixed hardcoded route &prefix in UPGRADE-1.8 document 1e9cdb9 Revert route name change
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.